Repository navigation
fix(tornado): use get_list() for multi-value headers in tornadoparser - #1118
Closed
abu-tahir-0 wants to merge 1 commit into
Closed
abu-tahir-0 wants to merge 1 commit into
abu-tahir-0 wants to merge 1 commit into
Conversation
Collaborator
|
This PR violates our AI Policy. Please read and take time to digest and understand the policy. Sending us LLM outputs without any investment of real effort is actively harmful to the project maintainers and therefore harmful to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When parsing headers with Tornado, tornado.httputil.HTTPHeaders.get(key) returns multiple values as a single comma-delimited string (e.g. 'foo,bar'). In WebArgsTornadoMultiDictProxy, iterating over this string when the field is multi-valued (e.g. fields.List(...)) yielded each individual character (['f', 'o', 'o', ',', 'b', 'a', 'r']) instead of the distinct header values ['foo', 'bar'].
Root Cause
WebArgsTornadoMultiDictProxy.getitem unconditionally called self.data.get(key) to retrieve the value. For tornado.httputil.HTTPHeaders, get() concatenates repeated header values with commas, whereas get_list(key) returns the list of individual header values. Additionally, MultiDictProxy.getitem checked getlist and getall, but not Tornado's get_list method name.
Solution
Testing
Impact
Allows multi-value headers to be parsed into correct list values under Tornado without character splitting.
Fixes #1109